[PATCH] D126939: [SLP] Avoid converting undef to poison when gathering.

Nuno Lopes via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jun 4 00:59:04 PDT 2022


nlopes added inline comments.


================
Comment at: llvm/test/Transforms/SLPVectorizer/X86/slp-fma-loss.ll:55
 ; CHECK-NEXT:    [[TMP1:%.*]] = insertelement <4 x double> poison, double [[CVT0]], i32 0
-; CHECK-NEXT:    [[SHUFFLE:%.*]] = shufflevector <4 x double> [[TMP1]], <4 x double> poison, <4 x i32> zeroinitializer
-; CHECK-NEXT:    [[TMP2:%.*]] = fmul fast <4 x double> <double 7.000000e+00, double -4.300000e+01, double 2.200000e-02, double 9.500000e+00>, [[SHUFFLE]]
----------------
I second @hvdijk's comment. Your last update to the patch introduced significant regressions.
This function was just fine and shouldn't be affected by the patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126939/new/

https://reviews.llvm.org/D126939



More information about the llvm-commits mailing list