[PATCH] D126885: [SLP]Cost for a constant buildvector.

[Alexey Bataev via Phabricator via llvm-commits]

ABataev added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:5802
+      } else {
+        InstructionCost ScalarCost = 0;
+        for (Value *V : VL) {
----------------
vdmitrie wrote:
> ABataev wrote:
> > vdmitrie wrote:
> > > drop it?
> > What do you mean?
> Drop extra definition of ScalarCost.
> Otherwise loop at line 5807 is updating variable from 5802,  but it is not used.
> LIne 5811 will subtract one defined at 5795.
> 
Ah, yes, sure.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126885/new/

https://reviews.llvm.org/D126885