[PATCH] D126116: [X86][BOLT][NFC] Use getOperandType to determine memory access size
Rafael Auler via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 3 12:17:04 PDT 2022
rafauler added a comment.
Btw from BOLT perspective this diff LGTM. Regarding the changes to X86 target, those look minimal and rather benign to me. It is apparently using tablegen info (GET_INSTRINFO_OPERAND_TYPE) that is not used by any other backend that is in-tree, but TableGen supports generating this info and it is even in their testsuite. Even if it has a bug because it hasn't been used, I think it makes sense to try for us as it obviously won't break any existing code as we are the only users of this information. We should wait for someone responsible for the X86 target to approve this change, though.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126116/new/
https://reviews.llvm.org/D126116
More information about the llvm-commits
mailing list