[PATCH] D126950: [lld][WebAssembly] Retain data segments referenced via __start/__stop

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added inline comments.


================
Comment at: lld/test/wasm/gc-sections-metadata-startstop.s:2
+# RUN: llvm-mc -triple=wasm32-unknown-unknown -filetype=obj -o %t.o %s
+# RUN: wasm-ld %t.o --gc-sections -o %t.wasm
+# RUN: llvm-objdump -d --no-show-raw-insn %t.wasm | FileCheck %s
----------------
`--gc-sections` is the default under wasm so you don't need that here.


================
Comment at: lld/test/wasm/gc-sections-metadata-startstop.s:90
+	.section	invalid.dot.name,"",@
+	.globl	invalid_name_section
+invalid_name_section:
----------------
I think you can drop the `.globl` for everything but `_start` without effecting the test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126950/new/

https://reviews.llvm.org/D126950