[PATCH] D126791: [AMDGPU][GFX9+] Support base+soffset+offset s_atc_probe's.
Dmitry Preobrazhensky via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 3 09:04:52 PDT 2022
dp accepted this revision.
dp added a comment.
This revision is now accepted and ready to land.
LGTM with a nit.
================
Comment at: llvm/lib/Target/AMDGPU/SMInstructions.td:250
+ (ins SReg_32:$soffset, smem_offset_mod:$offset), "$soffset$offset",
+ /* hasOffset= */ 1, /* hasSOffset= */ 1>;
}
----------------
IMO these comments distract attention and make code less readable.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126791/new/
https://reviews.llvm.org/D126791
More information about the llvm-commits
mailing list