[PATCH] D126893: [RISCV] simplify emitVSETVLIs handling of vsetvli xN, phi(), vtype case [NFC]

[Philip Reames via Phabricator via llvm-commits]

reames added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVInsertVSETVLI.cpp:1135
           insertVSETVLI(MBB, MI, NewInfo, CurInfo);
-          CurInfo = NewInfo;
-        }
+        PrefixTransparent = true;
+        CurInfo = NewInfo;
----------------
frasercrmck wrote:
> craig.topper wrote:
> > Why is this one `true`? If we insert a vsetvli in the body of the above if, don't we need to not use needVSETVLIPHI in the future?
> I was also wondering that.
Because that's a flat out bug in the patch.  Oops!

Fixed in the new version.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126893/new/

https://reviews.llvm.org/D126893