[PATCH] D126725: [pseudo] rename pseudo-gen -> clang-pseudo-gen. NFC
Nico Weber via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 3 07:44:08 PDT 2022
thakis added a comment.
Renaming this seems like a great change to me fwiw :)
================
Comment at: llvm/utils/gn/secondary/clang-tools-extra/pseudo/gen/BUILD.gn:1
-executable("pseudo-gen") {
+executable("clang-pseudo-gen") {
configs += [ "//llvm/utils/gn/build:clang_code" ]
----------------
hokein wrote:
> I was skeptical there should be an additional change in the gn build (building the inc file), but it looks like the gn file is incomplete, the `cxx` doesn't compile in gn build, there is a [fixme](https://github.com/llvm/llvm-project/blob/main/llvm/utils/gn/secondary/clang-tools-extra/pseudo/cxx/BUILD.gn#L2), I think it is ok.
(fwiw we usually only add things to the gn build covered by tests. nothing in the test suite needs this at the moment, so i haven't ported it. i have a local branch ready to go in case it's needed, it looks like D126966.)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126725/new/
https://reviews.llvm.org/D126725
More information about the llvm-commits
mailing list