[PATCH] D126931: [llvm-ml] Remove all file extension restrictions
Hans Wennborg via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 3 04:42:16 PDT 2022
hans added a comment.
> However, this is a problem on *nix systems as a leading forward slash
> there is a valid file path. To partially mitigate this, we now consider
> such inputs invalid arguments if they begin with a forward slash and do
> *not* contain any more further forward slash characters. Everything else
> is treated as a filename and we emit an appropriate error.
Both clang-cl and lld-link have the same problem. The way they handle it, they treat everything that's not a flag as a filename. For example:
clang-cl /c /nnlogo
clang-cl: error: no such file or directory: '/nnlogo'; did you mean '/nologo'?
clang-cl: error: no input files
lld-link /nnlogo a.obj
lld-link: error: could not open '/nnlogo': no such file or directory; did you mean '/nologo'
The "did you mean" is perhaps not strictly necessary, but makes it a little more user friendly.
Could we do the same for llvm-ml?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126931/new/
https://reviews.llvm.org/D126931
More information about the llvm-commits
mailing list