[PATCH] D126939: [SLP] Avoid converting undef to poison when gathering.

Alexey Bataev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 3 04:14:06 PDT 2022


ABataev added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:7559
         NumValues = VF;
+      } else if (UniqueValues.size() == 1 && NumValues == 1) {
+        NumValues = VF;
----------------
vporpo wrote:
> @ABataev I am not sure this is the right fix for it, please take a look.
I think you need to drop `&& NumValues == 1` check, otherwise we may miss something like `undef, 0, under, undef`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126939/new/

https://reviews.llvm.org/D126939



More information about the llvm-commits mailing list