[PATCH] D126893: [RISCV] simplify emitVSETVLIs handling of vsetvli xN, phi(), vtype case [NFC]

[Fraser Cormack via Phabricator via llvm-commits]

frasercrmck added a comment.

I think the simplification is good and I'd like to see something like this. Starting off with predecessor info is logical.

I'm not sure about the name `PrefixTransparent` though - I think that variable needs explanation (in a comment) because, personally, the name doesn't do it on its own.



================
Comment at: llvm/lib/Target/RISCV/RISCVInsertVSETVLI.cpp:1135
           insertVSETVLI(MBB, MI, NewInfo, CurInfo);
-          CurInfo = NewInfo;
-        }
+        PrefixTransparent = true;
+        CurInfo = NewInfo;
----------------
craig.topper wrote:
> Why is this one `true`? If we insert a vsetvli in the body of the above if, don't we need to not use needVSETVLIPHI in the future?
I was also wondering that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126893/new/

https://reviews.llvm.org/D126893