[PATCH] D126942: [llvm-lib] Add dot product tests

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a comment.

Thanks for the patch. For the title, it's quite common for LLVM patches to use `[PassName]` prefix, so for this one `[LowerMatrixIntrinsics]`.



================
Comment at: llvm/test/Transforms/LowerMatrixIntrinsics/dot-product.ll:5
+
+define <1 x float> @dotproduct_float_v6(<6 x float> %a, <6 x float> %b) {
+; CHECK-LABEL: @dotproduct_float_v6(
----------------
it might be good to also throw in a test with inputs that don't take up a full register, like `<3 x float>`, maybe also `<1 x float>`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126942/new/

https://reviews.llvm.org/D126942