[PATCH] D126910: [Alignment][NFC] Remove usage of MemSDNode::getAlignment

[Clement Courbet via Phabricator via llvm-commits]

courbet added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMISelLowering.cpp:5583
+                          Ld->getPointerInfo().getWithOffset(4),
+                          std::min(Ld->getAlign(), Align(4)),
                           Ld->getMemOperand()->getFlags());
----------------
Even though this works, I think this is conceptually misleading: `4` here is an offset, not an alignment. So I think this should be:

`commonAlignment(Ld->getAlign(), 4)`




================
Comment at: llvm/lib/Target/ARM/ARMISelLowering.cpp:14797
                                  LD->getPointerInfo().getWithOffset(4),
-                                 std::min(4U, LD->getAlignment()),
+                                 std::min(LD->getAlign(), Align(4)),
                                  LD->getMemOperand()->getFlags());
----------------
ditto


================
Comment at: llvm/lib/Target/Mips/MipsSEISelLowering.cpp:1186
       MVT::i32, DL, Lo.getValue(1), Ptr, MachinePointerInfo(),
-      std::min(Nd.getAlignment(), 4U), Nd.getMemOperand()->getFlags());
+      std::min(Nd.getAlign(), Align(4)), Nd.getMemOperand()->getFlags());
 
----------------
ditto


================
Comment at: llvm/lib/Target/Mips/MipsSEISelLowering.cpp:1221
   return DAG.getStore(Chain, DL, Hi, Ptr, MachinePointerInfo(),
-                      std::min(Nd.getAlignment(), 4U),
+                      std::min(Nd.getAlign(), Align(4)),
                       Nd.getMemOperand()->getFlags(), Nd.getAAInfo());
----------------
ditto


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:15317
           LD->getPointerInfo().getWithOffset(4),
-          MinAlign(LD->getAlignment(), 4), MMOFlags, LD->getAAInfo());
+          std::min(LD->getAlign(), Align(4)), MMOFlags, LD->getAAInfo());
 
----------------
ditto



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126910/new/

https://reviews.llvm.org/D126910