[PATCH] D126940: github: Fix release automation /branch command with new repo

Tobias Hieta via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 2 23:04:39 PDT 2022


thieta added a comment.

This looks good - only a comment about error handling, but I think we can also address that later if we see it's a large problem.



================
Comment at: llvm/utils/git/github-automation.py:322
+            local_repo = Repo(self.llvm_project_dir)
+            local_repo.git.fetch(f'https://github.com/{owner}/llvm-project', f'{branch}:{branch}')
+            local_repo.git.push(self.push_url, f'{branch}:{branch}', force=True)
----------------
Maybe there should be some error handling here? this block can be retried if fetch or push fails - network errors happens fairly often.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126940/new/

https://reviews.llvm.org/D126940



More information about the llvm-commits mailing list