[PATCH] D126933: [BOLT] Restrict execution of tests that fail on Windows

Amir Ayupov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 2 19:16:35 PDT 2022


Amir added a comment.

I've recently added some magic to pass linux target triple to cflags in bolt/test/lit.local.cfg:

  host_linux_triple = config.target_triple.split('-')[0]+'-linux'
  common_linker_flags = '-fuse-ld=lld -Wl,--unresolved-symbols=ignore-all'
  flags = f'--target={host_linux_triple} {common_linker_flags}'

This would take the arch from target triple (x86_64 or aarch64) and append `-linux`. I didn't test it on Windows but it works on macOS. Therefore I'm reluctant to add `system-linux` to these tests that would restrict them to linux.

Can you please share what's passed as cflags on windows? Let's try to fix it. Our tests don't depend on system headers, so there's a good chance they would work even on windows.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126933/new/

https://reviews.llvm.org/D126933



More information about the llvm-commits mailing list