[PATCH] D126917: [AMDGPU] gfx11 VOP1+VOP2 Instruction MC support

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 2 16:18:20 PDT 2022


rampitec added a comment.

LGTM, except for unrelated SMRD tests.



================
Comment at: llvm/test/MC/Disassembler/AMDGPU/gfx11_dasm_all.txt:10411
 
-# GFX11: v_add3_u32 v255, v1, v2, v3             ; encoding: [0xff,0x00,0x55,0xd6,0x01,0x05,0x0e,0x04]
-0xff,0x00,0x55,0xd6,0x01,0x05,0x0e,0x04
+# GFX11: s_load_b32 s101, s[2:3], s0             ; encoding: [0x41,0x19,0x00,0xf4,0x00,0x00,0x00,0x00]
+0x41,0x19,0x00,0xf4,0x00,0x00,0x00,0x00
----------------
Can you please submit this portion separately? It is unrelated (and NFC as well, so not need to review).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126917/new/

https://reviews.llvm.org/D126917



More information about the llvm-commits mailing list