[PATCH] D126921: [RISCV] Untangle instruction properties from VSETVLIInfo [NFC]

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 2 14:10:16 PDT 2022


reames created this revision.
reames added reviewers: frasercrmck, craig.topper, kito-cheng.
Herald added subscribers: sunshaoce, VincentWu, luke957, StephenFan, vkmr, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, niosHD, sabuasal, bollu, simoncook, johnrusso, rbar, asb, hiraditya, arichardson, mcrosier.
Herald added a project: All.
reames requested review of this revision.
Herald added subscribers: pcwang-thead, eopXD, MaskRay.
Herald added a project: LLVM.

The abstract state used in the data flow should not know anything about the instructions which produced the abstract states.  Instead, when comparing two states, we can simply use information about the machine instr at that time.

In the old design, basically any use of the instruction flags on the current (as opposed to a "Require" - aka upcoming state) would be a bug.  We don't seem to actually have any such bugs, but we can make this much more obvious with code structure.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D126921

Files:
  llvm/lib/Target/RISCV/RISCVInsertVSETVLI.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D126921.433885.patch
Type: text/x-patch
Size: 10387 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220602/c46c70d5/attachment.bin>


More information about the llvm-commits mailing list