[PATCH] D126833: [SampleProfile][Inline] Annotate sample profile inline remarks with link phase (prelink/postlink) information.

Mingming Liu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 2 14:01:26 PDT 2022


mingmingl updated this revision to Diff 433880.
mingmingl added a comment.

- Fix a bug in `InlineAdvisor::getAnnotatedInlinePassName` (from https://reviews.llvm.org/D126824). Basically, to compute string only once, make it a constant member of class, and return its `c_str()` ever since.

- Let SampleProfileLoader class call `llvm::AnnotateInlinePassName` to get an annotated name.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126833/new/

https://reviews.llvm.org/D126833

Files:
  llvm/include/llvm/Analysis/InlineAdvisor.h
  llvm/include/llvm/Transforms/IPO/SampleProfile.h
  llvm/lib/Analysis/InlineAdvisor.cpp
  llvm/lib/Transforms/IPO/SampleProfile.cpp
  llvm/test/Transforms/SampleProfile/pseudo-probe-inline.ll
  llvm/test/Transforms/SampleProfile/remarks.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D126833.433880.patch
Type: text/x-patch
Size: 12677 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220602/4e7baebf/attachment.bin>


More information about the llvm-commits mailing list