[PATCH] D126236: [CaptureTracking] Increase limit but use it for all visited uses.

[Florian Hahn via Phabricator via llvm-commits]

fhahn marked an inline comment as done.
fhahn added inline comments.


================
Comment at: llvm/lib/Analysis/CaptureTracking.cpp:452
       // is captured to avoid taking too much compile time.
       if (Count++ >= MaxUsesToExplore) {
         Tracker->tooManyUses();
----------------
reames wrote:
> aeubanks wrote:
> > does moving this after `Visited.insert()` below help at all? I'd think that going through the worklist below is the expensive part, not constructing the worklist
> It also feels odd to count uses we chose not to explore.  Maybe we should simply count the number of items we pull off the worklist, not the addition at all?
Good point, I'll adjust that in the commit, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126236/new/

https://reviews.llvm.org/D126236