[PATCH] D126898: [COFF] Check table ptr more thoroughly and ignore empty sections

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 2 13:18:15 PDT 2022


mstorsjo added inline comments.


================
Comment at: llvm/lib/Object/COFFObjectFile.cpp:902
+    if (E.isA<SectionStrippedError>())
+      consumeError(std::move(E));
+    else
----------------
The patch overall looks reasonable to me. The changes to this function feel a bit clunky, but I don't really have any other good suggestions either.

@rnk, what do you think about this patch?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126898/new/

https://reviews.llvm.org/D126898



More information about the llvm-commits mailing list