[PATCH] D126895: [SLP] Phi inputs that come from an unreachable block should be undef.

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 2 13:02:48 PDT 2022


nikic requested changes to this revision.
nikic added a comment.
This revision now requires changes to proceed.

> I understand that poison is the preferred input to the phis. But given that it is not, then shouldn't SLP try to maintain the program semantics?

SLP does maintain program semantics: The phi value for an unreachable block doesn't matter, it can be poison, undef, 42, or anything else.

As has been asked multiple times, please explain the problem you're trying to fix in a larger context.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126895/new/

https://reviews.llvm.org/D126895



More information about the llvm-commits mailing list