[PATCH] D115674: [runtime] Build compiler-rt with --unwindlib=none

Thu Jun 2 12:54:02 PDT 2022

phosek added inline comments.
Herald added a subscriber: Enna1.

================
Comment at: compiler-rt/CMakeLists.txt:512
+    # default libunwind (which may be missing still).
+    append_list_if(CXX_SUPPORTS_UNWINDLIB_NONE_FLAG --unwindlib=none SANITIZER_COMMON_LINK_FLAGS)
+
----------------
mstorsjo wrote:
> I presume we should only do this if we actually know we're linking against a libunwind that is built in the same cmake invocation, i.e. either of the `TARGET unwind_* OR HAVE_LIBUNWIND` cases below, otherwise this does break things.
Yes, I hope this could be more cleanly addressed by D126909.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115674/new/

https://reviews.llvm.org/D115674