[PATCH] D99179: [RFC] [Coroutines] Enable printing coroutine frame in debugger if program is compiled with -g

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

In D99179#3553124 <https://reviews.llvm.org/D99179#3553124>, @probinson wrote:

> @ChuanqiXu the use of DW_ATE_address was a surprise to our debugger; it is a very unusual encoding, and there are no other uses of it within LLVM.  I see there was no Release Note regarding the description of coroutine frames, which might have helped us notice.
>
> More importantly, I see two places where DW_ATE_address is used in constructing the DWARF, and yet the tests do not look for it.  Please enhance the tests to cover these cases.  I can file an issue if you would like, to keep track of this.

Hmm, yeah, that's curious. Also seems noteworthy (I only checked quickly, so maybe I missed something) there seems to be no mention of DW_ATE_address in the test cases. Maybe missing test coverage?

But to produce more common/likely-usable DWARF would be to use a pointer_type with no DW_ATE attribute (that's what Clang/LLVM produce for "void*" (DW_TAG_pointer_type with no attributes))


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99179/new/

https://reviews.llvm.org/D99179