[PATCH] D126861: [RISCV] Fix missing stack pointer recover

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 2 09:40:05 PDT 2022


reames added a comment.

I'm missing something here.

If we have a frame pointer, shouldn't restoring SP simply be a register move?  Why bother with all of the offset adjustments in this case at all?  Shouldn't we be able to structure the code as:
if (hasFP) {

  copy SP to FP

} else {

  do it the hard way

}


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126861/new/

https://reviews.llvm.org/D126861



More information about the llvm-commits mailing list