[PATCH] D126778: [LoopVectorize] Add FastMathFlags to the select used for reductions with tail-folding

[Sanjay Patel via Phabricator via llvm-commits]

spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

LGTM - see inline comment for a possible minor improvement.



================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:3917
       Value *VecLoopExitInst = State.get(LoopExitInstDef, Part);
       Value *Sel = nullptr;
       for (User *U : VecLoopExitInst->users()) {
----------------
Given the variable name, shouldn't this be a 'SelectInst*' rather than a 'Value*'? Then we wouldn't need the cast<> in the new line of code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126778/new/

https://reviews.llvm.org/D126778