[PATCH] D126860: [RISCV] Pre-commit testcase for PR55442

[Kito Cheng via Phabricator via llvm-commits]

kito-cheng created this revision.
Herald added subscribers: sunshaoce, VincentWu, luke957, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, niosHD, sabuasal, simoncook, johnrusso, rbar, asb, arichardson.
Herald added a project: All.
kito-cheng requested review of this revision.
Herald added subscribers: llvm-commits, pcwang-thead, eopXD, MaskRay.
Herald added a project: LLVM.

The testcase show the stack pointer isn't recovered when we got
exception from `_Z3fooiiiiiiiiiiPi`, and then we screw up due to
restore return address from wrong stack pointer.

NOTE: Trigger conditions:
1. Frame pointer is required.
2. Stack has out-going argument
3. Vector extension is enabled.

Another run-able testcase:

$ clang++ -target riscv64-unknown-linux-gnu -march=rv64gcv test.cpp

  void __attribute__((noinline)) foo(int, int, int, int, int, int, int, int, int, int, int *){
   throw int(0);
  }
  
  int main(int argc, char **argv) {
    int exception_value = 1;
    try {
        foo(0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0);
    } catch (int i) {
      exception_value = i;
    }
    return exception_value;
  }


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D126860

Files:
  llvm/test/CodeGen/RISCV/miss-sp-restore-eh.ll


Index: llvm/test/CodeGen/RISCV/miss-sp-restore-eh.ll
===================================================================
--- /dev/null
+++ llvm/test/CodeGen/RISCV/miss-sp-restore-eh.ll
@@ -0,0 +1,92 @@
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc -mtriple=riscv64 -mattr=+v,+m < %s \
+; RUN:     | FileCheck %s
+
+
+ at _ZTIi = external dso_local constant ptr
+
+declare void @_Z3fooiiiiiiiiiiPi(i32 signext %0, i32 signext %1, i32 signext %2, i32 signext %3, i32 signext %4, i32 signext %5, i32 signext %6, i32 signext %7, i32 %8, i32 %9, i32 %10)
+
+declare dso_local ptr @__cxa_allocate_exception(i64)
+
+declare dso_local void @__cxa_throw(ptr, ptr, ptr)
+
+define signext i32 @foo() #1 personality ptr @__gxx_personality_v0 {
+; CHECK-LABEL: foo:
+; CHECK:       # %bb.0: # %entry
+; CHECK-NEXT:    addi sp, sp, -32
+; CHECK-NEXT:    .cfi_def_cfa_offset 32
+; CHECK-NEXT:    sd ra, 24(sp) # 8-byte Folded Spill
+; CHECK-NEXT:    sd s0, 16(sp) # 8-byte Folded Spill
+; CHECK-NEXT:    sd s1, 8(sp) # 8-byte Folded Spill
+; CHECK-NEXT:    .cfi_offset ra, -8
+; CHECK-NEXT:    .cfi_offset s0, -16
+; CHECK-NEXT:    .cfi_offset s1, -24
+; CHECK-NEXT:    addi s0, sp, 32
+; CHECK-NEXT:    .cfi_def_cfa s0, 0
+; CHECK-NEXT:  .Ltmp0:
+; CHECK-NEXT:    addi sp, sp, -32
+; CHECK-NEXT:    li a0, 0
+; CHECK-NEXT:    li a1, 0
+; CHECK-NEXT:    li a2, 0
+; CHECK-NEXT:    li a3, 0
+; CHECK-NEXT:    li a4, 0
+; CHECK-NEXT:    li a5, 0
+; CHECK-NEXT:    li a6, 0
+; CHECK-NEXT:    li a7, 0
+; CHECK-NEXT:    call _Z3fooiiiiiiiiiiPi at plt
+; CHECK-NEXT:    addi sp, sp, 32
+; CHECK-NEXT:  .Ltmp1:
+; CHECK-NEXT:  # %bb.1: # %try.cont.unreachable
+; CHECK-NEXT:  .LBB0_2: # %lpad
+; CHECK-NEXT:  .Ltmp2:
+; CHECK-NEXT:    sext.w a1, a1
+; CHECK-NEXT:    li a2, 1
+; CHECK-NEXT:    bne a1, a2, .LBB0_4
+; CHECK-NEXT:  # %bb.3: # %catch
+; CHECK-NEXT:    call __cxa_begin_catch at plt
+; CHECK-NEXT:    lw s1, 0(a0)
+; CHECK-NEXT:    call __cxa_end_catch at plt
+; CHECK-NEXT:    mv a0, s1
+; CHECK-NEXT:    ld ra, 24(sp) # 8-byte Folded Reload
+; CHECK-NEXT:    ld s0, 16(sp) # 8-byte Folded Reload
+; CHECK-NEXT:    ld s1, 8(sp) # 8-byte Folded Reload
+; CHECK-NEXT:    addi sp, sp, 32
+; CHECK-NEXT:    ret
+; CHECK-NEXT:  .LBB0_4: # %ehcleanup
+; CHECK-NEXT:    call _Unwind_Resume at plt
+entry:
+  invoke void @_Z3fooiiiiiiiiiiPi(i32 signext poison, i32 signext poison, i32 signext poison, i32 signext poison, i32 signext poison, i32 signext poison, i32 signext poison, i32 signext poison, i32 poison, i32 poison, i32 poison)
+          to label %try.cont.unreachable unwind label %lpad
+
+lpad:
+  %0 = landingpad { ptr, i32 }
+          cleanup
+          catch ptr @_ZTIi
+  %1 = extractvalue { ptr, i32 } %0, 1
+  %2 = call i32 @llvm.eh.typeid.for(ptr nonnull @_ZTIi)
+  %matches = icmp eq i32 %1, %2
+  br i1 %matches, label %catch, label %ehcleanup
+
+catch:
+  %3 = extractvalue { ptr, i32 } %0, 0
+  %4 = call ptr @__cxa_begin_catch(ptr %3)
+  %5 = load i32, ptr %4, align 4
+  call void @__cxa_end_catch()
+  ret i32 %5
+
+try.cont.unreachable:
+  unreachable
+
+ehcleanup:
+  resume { ptr, i32 } %0
+}
+
+declare i32 @__gxx_personality_v0(...)
+
+declare i32 @llvm.eh.typeid.for(ptr)
+
+declare ptr @__cxa_begin_catch(ptr)
+declare void @__cxa_end_catch()
+
+attributes #1 = { "frame-pointer"="all"}


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D126860.433686.patch
Type: text/x-patch
Size: 3336 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220602/352a08b9/attachment.bin>