[PATCH] D126807: [PowerPC] Fix LQ-STQ instructions to use correct offset and base

[Nemanja Ivanovic via Phabricator via llvm-commits]

nemanjai added a comment.

In D126807#3551902 <https://reviews.llvm.org/D126807#3551902>, @lkail wrote:

> I think the root cause here is `lq/stq` is lacking x-form. There are `LQX_PSEUDO` and `STQX_PSEUDO` defined to assist accessing big offset inside stack/heap, but they are expanded pre-RA. I think we should expand them in `PPCAtomicExpandPass`(which is after prologepilog) and make `lq/stq`'s x-form mapping to `LQX_PSEUDO/STQX_PSEUDO`.

This really doesn't seem like an instruction we should be expanding prior to RA (i.e. there is no reason for it to be a `PPCCustomInserterPseudo`). It should probably just be a `PPCPostRAExpPseudo`. That would be expanded in `PPCInstrInfo::expandPostRAPseudo()`. Wouldn't that be late enough?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126807/new/

https://reviews.llvm.org/D126807