[PATCH] D125847: LTO: Decide upfront whether to use opaque/non-opaque pointer types

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/tools/gold/gold-plugin.cpp:966
 
+  Config.OpaquePointers = options.opaque_pointers;
+
----------------
MatzeB wrote:
> MaskRay wrote:
> > `Conf`?
> > 
> > 
> Ouch, good catch. Guess we have no form of direct testing of the gold plugin in LLVM...
Sanitizers have bots using `-DLLVM_BINUTILS_INCDIR=/usr/include`, but otherwise using this option is uncommon among build bots.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125847/new/

https://reviews.llvm.org/D125847