[PATCH] D126834: [memprof] Display segment information, update summary output.

Wed Jun 1 16:26:59 PDT 2022

tejohnson added a comment.

I think the 2 changes are unrelated so maybe they should be committed separately? Question below about one piece of info that changed.

================
Comment at: llvm/lib/ProfileData/RawMemProfReader.cpp:229
+  OS << "    NumSegments: " << SegmentInfo.size() << "\n";
+  OS << "    NumAllocFunctions: " << NumAllocFunctions << "\n";
+  OS << "    NumStackOffsets: " << StackMap.size() << "\n";
----------------
It looks like before we printed out the number of MIBs and now we print out the number of functions containing at least one alloc - is that intended? Should we print out both?

================
Comment at: llvm/test/tools/llvm-profdata/memprof-multi.test:38

 We expect 2 MIB entries, 1 each for the malloc calls in the program.

----------------
Comment seems stale unless the summary is changed to print number of MIBs again.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126834/new/

https://reviews.llvm.org/D126834