[PATCH] D126809: [ARM64EC 8/?] Implement ARM64EC "thunk" calling conventions

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: llvm/include/llvm/IR/CallingConv.h:258
+    /// ARM64 register names. The first parameter is mapped to x9.
+    ARM64EC_Thunk_X64 = 102,
+
----------------
dpaoliello wrote:
> When adding a calling convention, does it not also need to be added to the IR AsmWriter/AsmPrinter?
If you don't add it to the asmparser/writer, there's some default handling that just uses the number, I think.  But it might be better to give them proper names in IR.

Alternatively, I was thinking about marking the calls using an attribute instead of a calling convention.  Which is basically equivalent to using a calling convention, but doesn't consume calling convention numbers.  Probably doesn't matter much in practice.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126809/new/

https://reviews.llvm.org/D126809