[PATCH] D126826: [BOLT][NFC] Replacing stdio functions with raw_ostream functions

Huan Nguyen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 1 15:19:36 PDT 2022


nhuhuan added inline comments.


================
Comment at: bolt/include/bolt/Passes/CallGraph.h:19
+#include <iomanip>
+#include <string>
 #include <unordered_set>
----------------
Amir wrote:
> Are all of the new includes here really needed? Can you please prune the added includes as much as possible?
I included cmath and iomanip to use std::fixed and std::setprecision to get right format for floating-point value.
But they are not compatible with raw_ostream, so I removed them, and forgot to remove cmath.
Including <string> is not necessary as it was already included in llvm/Support/FileSystem.h.
I will remove all of them in the next commit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126826/new/

https://reviews.llvm.org/D126826



More information about the llvm-commits mailing list