[PATCH] D114845: [llvm] [Debuginfod] DebuginfodCollection and DebuginfodServer for tracking local debuginfo.

[Noah Shutty via Phabricator via llvm-commits]

noajshu marked an inline comment as done.
noajshu added inline comments.


================
Comment at: llvm/lib/Debuginfod/Debuginfod.cpp:341
+      if (isDebugBinary(Object)) {
+        bool LockSucceeded = DebugBinariesMutex.lock();
+        assert(LockSucceeded && "Failed to acquire writer lock.");
----------------
noajshu wrote:
> mysterymath wrote:
> > std::lock_guard should work with RWMutexes for exclusive locking, and it's easier to read than doing it manually.
> Thanks! Since we're `std::shared_lock<RWMutex> lock(write);
> 
Good idea, I switched everything to use `std::` raii locks and it's much cleaner.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114845/new/

https://reviews.llvm.org/D114845