[PATCH] D126411: update_mir_test_checks: Better handling of common prefixes

Nicolai Hähnle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 1 13:52:57 PDT 2022


nhaehnle marked 2 inline comments as done.
nhaehnle added inline comments.


================
Comment at: llvm/test/tools/UpdateTestChecks/update_mir_test_checks/Inputs/x86-multiple-prefixes.ll.expected:2
+; NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
+; RUN: llc < %s -mtriple=x86_64-apple-darwin -stop-after=instruction-select | FileCheck --check-prefixes=CHECK,NOAVX %s
+; RUN: llc < %s -mtriple=x86_64-apple-darwin -stop-after=instruction-select -mattr=avx | FileCheck --check-prefixes=CHECK,AVX %s
----------------
aemerson wrote:
> arsenm wrote:
> > Using -stop-after=instruction-select without -global-isel only works by accident. Probably should pick a different stopping point
> Yeah, the right one is probably `finalize-isel`
> Yeah, the right one is probably `finalize-isel`

Thanks, I'm adjusting the test before I push.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126411/new/

https://reviews.llvm.org/D126411



More information about the llvm-commits mailing list