[PATCH] D126421: ADT/ArrayRef: Add makeMutableArrayRef overloads

[Nicolai Hähnle via Phabricator via llvm-commits]

nhaehnle marked 2 inline comments as done.
nhaehnle added inline comments.


================
Comment at: llvm/include/llvm/ADT/ArrayRef.h:549
+
+  template <typename T, unsigned N>
+  MutableArrayRef<T> makeMutableArrayRef(SmallVector<T, N> &Vec) {
----------------
MaskRay wrote:
> efriedma wrote:
> > Missing doc comment?
> Adding a comment for each makeMutableArrayRef overload doesn't add much value to me. The argument types are obvious.
> 
> I think having one comment covering all the overloads suffices.
This just feels like a matter of taste. The patch as-is follows the existing convention in the file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126421/new/

https://reviews.llvm.org/D126421