[PATCH] D126787: [llvm-objdump][COFF] Remove duplicate data dir loading

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 1 13:23:11 PDT 2022


mstorsjo added reviewers: mstorsjo, rnk.
mstorsjo added a comment.

This also needs a testcase.

The description makes it sound like this is a NFC (a commit that only does pure refactoring, "No Functional Changes"), but the detail that isn't entirely obvious is that this also fixes printing (by skipping it) for the cases where there is a data directory, but the contents it points at is missing, so maybe it'd be good to spell this out a bit more clearly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126787/new/

https://reviews.llvm.org/D126787



More information about the llvm-commits mailing list