[PATCH] D126785: Cache file IDs of symbols in emitStabs for faster sorting
Nico Weber via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 1 11:53:44 PDT 2022
thakis added inline comments.
================
Comment at: lld/MachO/SyntheticSections.cpp:922
- llvm::stable_sort(symbolsNeedingStabs, [&](Defined *a, Defined *b) {
- return a->isec->getFile()->id < b->isec->getFile()->id;
+ llvm::stable_sort(symbolsNeedingStabs, [&](const SortingPair &a, const SortingPair &b) {
+ return a.second < b.second;
----------------
Oh sorry, I missed that this is > 80 columns. LLVM uses 80 columns. Run `git clang-format HEAD^` to make clang-format auto-format your code before sending out patches :)
Fixed this up in 815825f4426f91. Apologies again for missing it before committing.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126785/new/
https://reviews.llvm.org/D126785
More information about the llvm-commits
mailing list