[PATCH] D126611: [libunwind] Ensure test/libunwind_01.pass is not completely inlined

Wed Jun 1 10:46:39 PDT 2022

ldionne accepted this revision.
ldionne added inline comments.
This revision is now accepted and ready to land.

================
Comment at: libunwind/test/libunwind_01.pass.cpp:11
 // TODO: Investigate this failure on x86_64 macOS back deployment
 // XFAIL: use_system_cxx_lib && target=x86_64-apple-macosx{{10.9|10.10|10.11|10.12|10.13|10.14|10.15|11.0|12.0}}

----------------
arichardson wrote:
> @ldionne does the noinline fix the failure? I was originally testing on macOS and when I made this change (back in 2018) I believe it fixed the tests for me.
It doesn't look like it does, otherwise we'd have seen some XPASS in the CI.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126611/new/

https://reviews.llvm.org/D126611