[PATCH] D126793: [ELF] Remove support for legacy .zdebug sections

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/ELF/InputSection.cpp:73
 
-  // In ELF, each section can be compressed by zlib, and if compressed,
-  // section name may be mangled by appending "z" (e.g. ".zdebug_info").
-  // If that's the case, demangle section name so that we can handle a
-  // section as if it weren't compressed.
-  if ((flags & SHF_COMPRESSED) || name.startswith(".zdebug")) {
+  // If SHF_COMPRESSED is set, parse the header. The legacy .zdebug format is no
+  // longer supported.
----------------
peter.smith wrote:
> Possibly worth a warning message if a section prefix of `.zebug` is encountered? For example:
> ```LLD does not support legacy .zdebug compressed debug sections produced with -gz=zlib-gnu. Please rebuild with -gz=zlib.```
>   
I have thought about this, but removing `.zdebug` check is desired: this avoids a section name read when creating input sections.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126793/new/

https://reviews.llvm.org/D126793