[PATCH] D126046: [lld-macho] Support -non_global_symbols_strip_list, -non_global_symbols_no_strip_list, -x

[Vy Nguyen via Phabricator via llvm-commits]

oontvoo marked 5 inline comments as done.
oontvoo added a comment.

addressed in https://reviews.llvm.org/D126792



================
Comment at: lld/MachO/Driver.cpp:1418-1419
+  // takes effect.
+  // (TODO: This is kind of confusing - considering disallowing using them
+  // together for a more straightforward behaviour)
+  {
----------------
int3 wrote:
> did you have a build that used both together? IMO we should prefer implementation simplicity by default in cases where ld64's behavior is questionable
Yeah - can we keep this for now? (I'll  find out from the builds' owner whether the usage was intentional or if it could be cleaned up).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126046/new/

https://reviews.llvm.org/D126046