[PATCH] D126581: [Bazel][GN] Reuse the GN LLVM config file generation code

[Geoffrey Martin-Noble via Phabricator via llvm-commits]

GMNGeoffrey added a subscriber: chandlerc.
GMNGeoffrey added a comment.

I see you've already landed and reverted this. Apologies I didn't get to review in time. In previous iterations, we did have a python script for writing these config files that came from TensorFlow. I think it was less good than this one in terms of error detection. @chandlerc had strong opinions about not using a custom script here, I believe arguing that behavior that is "like CMake but not quite CMake" was likely to be error-prone. FWIW, I think this is overall an improvement (especially with its error detection instead of our existing config file copies), but I think it's worth bringing this up again. I think I even looked at using the GN script in Bazel and Chandler was against it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126581/new/

https://reviews.llvm.org/D126581