[PATCH] D124092: CodeGen: Remove MaxBytesForAlignment from MachineBasicBlock

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 1 09:02:45 PDT 2022


dmgreen added a comment.

It's used by AArch64, even if it's just a single value at the moment. getMaxPermittedBytesForAlignment should probably be called something like getMaxPermittedBytesForLoopAlignment. GCC sets different alignment/maxbytes for Loops vs Jumptable (vs Functions). You could imagine having different alignments/maxbytes for outer loops vs inner loops, or based on some other characteristics of the loop.

It is a value that seems to fit most naturally paired together with the Alignment on the MachineBasicBlock.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124092/new/

https://reviews.llvm.org/D124092



More information about the llvm-commits mailing list