[PATCH] D125688: [MCParser] Set default alignment value when meeting invalid align

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 1 06:32:02 PDT 2022


nikic added inline comments.


================
Comment at: llvm/lib/MC/MCParser/AsmParser.cpp:3457
+      Alignment = PowerOf2Floor(Alignment);
+    } else if (!isUInt<32>(Alignment)) {
       ReturnVal |= Error(AlignmentLoc, "alignment must be smaller than 2**32");
----------------
What if the alignment is a non-pow2 greater than 32-bit? I think that case will sneak through.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125688/new/

https://reviews.llvm.org/D125688



More information about the llvm-commits mailing list