[PATCH] D126776: Fix potentially uninitialized memory

[Mikhail Goncharov via Phabricator via llvm-commits]

goncharov created this revision.
Herald added a project: All.
goncharov requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

for https://github.com/llvm/llvm-project/commit/7d76d6095880f34914d85d876b260cc4a4ea640d


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D126776

Files:
  tools/driver/driver.cpp


Index: tools/driver/driver.cpp
===================================================================
--- tools/driver/driver.cpp
+++ tools/driver/driver.cpp
@@ -505,7 +505,10 @@
   bool IsCrash = false;
   Driver::CommandStatus CommandStatus = Driver::CommandStatus::Ok;
   // Pretend the first command failed if ReproStatus is Always.
-  const Command *FailingCommand = &*C->getJobs().begin();
+   const Command *FailingCommand = nullptr;
+  if (!C->getJobs().empty())
+    FailingCommand = &*C->getJobs().begin();
+
   if (C && !C->containsError()) {
     SmallVector<std::pair<int, const Command *>, 4> FailingCommands;
     Res = TheDriver.ExecuteCompilation(*C, FailingCommands);
@@ -542,7 +545,8 @@
   // crash, but only if we're crashing due to FORCE_CLANG_DIAGNOSTICS_CRASH.
   if (::getenv("FORCE_CLANG_DIAGNOSTICS_CRASH"))
     llvm::dbgs() << llvm::getBugReportMsg();
-  if (TheDriver.maybeGenerateCompilationDiagnostics(CommandStatus, ReproLevel,
+   if (FailingCommand != nullptr &&
+      TheDriver.maybeGenerateCompilationDiagnostics(CommandStatus, ReproLevel,
                                                     *C, *FailingCommand))
     Res = 1;
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D126776.433367.patch
Type: text/x-patch
Size: 1165 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220601/ee5fda39/attachment.bin>