[PATCH] D126287: [JITLink][ELF/AARCH64] Implement R_AARCH64_ADR_PREL_PG_HI21 and R_AARCH64_ADD_ABS_LO12_NC

[Stefan Gränitz via Phabricator via llvm-commits]

sgraenitz added a comment.

Thanks for your patch. The tests look good and appear to work fine on my machine. Will have a closer look at it towards the end of the week.



================
Comment at: llvm/lib/ExecutionEngine/JITLink/ELF_aarch64.cpp:57
+    case ELF::R_AARCH64_ADD_ABS_LO12_NC:
+      return ELF_aarch64_Edges::ELFAddAbs12;
     }
----------------
The `using namespace` on file level makes the explicit qualifications here redundant right? It's a detail, but let's agree on one option and stick to it consistently. (More cases below.)


================
Comment at: llvm/test/ExecutionEngine/JITLink/AArch64/ELF_aarch64_relocations.s:49
+        .globl  named_data
+        .p2align  4
+        .type   named_data, at object
----------------
The value of p2align varies between test cases. How does it affect the resolution? (Trying other values like 1 or 2 doesn't fail the test.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126287/new/

https://reviews.llvm.org/D126287