[PATCH] D125083: [RISCV] Use check-prefixes to reduce check lines
Fraser Cormack via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 1 00:25:17 PDT 2022
frasercrmck added inline comments.
================
Comment at: llvm/test/CodeGen/RISCV/double-fcmp-strict.ll:3
; RUN: llc -mtriple=riscv32 -mattr=+d -verify-machineinstrs < %s \
-; RUN: -disable-strictnode-mutation -target-abi=ilp32d \
-; RUN: | FileCheck -check-prefix=RV32IFD %s
+; RUN: -disable-strictnode-mutation -target-abi=ilp32d | FileCheck %s
; RUN: llc -mtriple=riscv64 -mattr=+d -verify-machineinstrs < %s \
----------------
`CHECKIFD` here I think since we still have RV32I and RV64I separate
================
Comment at: llvm/test/CodeGen/RISCV/double-fcmp.ll:3
; RUN: llc -mtriple=riscv32 -mattr=+d -verify-machineinstrs < %s \
-; RUN: -target-abi=ilp32d | FileCheck -check-prefix=RV32IFD %s
+; RUN: -target-abi=ilp32d | FileCheck %s
; RUN: llc -mtriple=riscv64 -mattr=+d -verify-machineinstrs < %s \
----------------
`CHECKIFD` here too
================
Comment at: llvm/test/CodeGen/RISCV/float-arith-strict.ll:4
; RUN: -disable-strictnode-mutation -target-abi=ilp32f \
-; RUN: | FileCheck -check-prefix=RV32IF %s
+; RUN: | FileCheck -check-prefixes=CHECKIFD,RV32IF %s
; RUN: llc -mtriple=riscv64 -mattr=+f -verify-machineinstrs < %s \
----------------
`CHECKIF` - there's no `D` in this test.
================
Comment at: llvm/test/CodeGen/RISCV/float-arith.ll:3
; RUN: llc -mtriple=riscv32 -mattr=+f -verify-machineinstrs < %s \
-; RUN: -target-abi=ilp32f | FileCheck -check-prefix=RV32IF %s
+; RUN: -target-abi=ilp32f | FileCheck %s
; RUN: llc -mtriple=riscv64 -mattr=+f -verify-machineinstrs < %s \
----------------
`CHECKIF` here because RV32I/RV64I are still used
================
Comment at: llvm/test/CodeGen/RISCV/float-convert-strict.ll:4
; RUN: -disable-strictnode-mutation -target-abi=ilp32f \
-; RUN: | FileCheck -check-prefix=RV32IF %s
+; RUN: | FileCheck -check-prefixes=CHECKIFD,RV32IF %s
; RUN: llc -mtriple=riscv64 -mattr=+f -verify-machineinstrs < %s \
----------------
`CHECKIF` - no `D`
================
Comment at: llvm/test/CodeGen/RISCV/float-convert.ll:3
; RUN: llc -mtriple=riscv32 -mattr=+f -verify-machineinstrs < %s \
-; RUN: -target-abi=ilp32f | FileCheck -check-prefix=RV32IF %s
+; RUN: -target-abi=ilp32f | FileCheck -check-prefixes=CHECKIFD,RV32IF %s
; RUN: llc -mtriple=riscv64 -mattr=+f -verify-machineinstrs < %s \
----------------
`CHECKIF`
================
Comment at: llvm/test/CodeGen/RISCV/float-fcmp-strict.ll:3
; RUN: llc -mtriple=riscv32 -mattr=+f -verify-machineinstrs < %s \
-; RUN: -disable-strictnode-mutation -target-abi=ilp32f \
-; RUN: | FileCheck -check-prefix=RV32IF %s
+; RUN: -disable-strictnode-mutation -target-abi=ilp32f | FileCheck %s
; RUN: llc -mtriple=riscv64 -mattr=+f -verify-machineinstrs < %s \
----------------
`CHECKIF`
================
Comment at: llvm/test/CodeGen/RISCV/float-fcmp.ll:3
; RUN: llc -mtriple=riscv32 -mattr=+f -verify-machineinstrs < %s \
-; RUN: -target-abi=ilp32f | FileCheck -check-prefix=RV32IF %s
+; RUN: -target-abi=ilp32f | FileCheck %s
; RUN: llc -mtriple=riscv64 -mattr=+f -verify-machineinstrs < %s \
----------------
`CHECKIF`
================
Comment at: llvm/test/CodeGen/RISCV/float-imm.ll:7
-; TODO: constant pool shouldn't be necessary for RV64IF.
+; TODO: constant pool shouldn't be necessary for RV64.
define float @float_imm() nounwind {
----------------
I think this comment should be left where it is - it refers to the architecture, not the check prefix.
================
Comment at: llvm/test/CodeGen/RISCV/float-intrinsics-strict.ll:4
; RUN: -verify-machineinstrs -disable-strictnode-mutation -target-abi=ilp32f \
-; RUN: | FileCheck -check-prefix=RV32IF %s
+; RUN: | FileCheck -check-prefixes=CHECKIFD,RV32IF %s
; RUN: sed 's/iXLen/i64/g' %s | llc -mtriple=riscv64 -mattr=+f \
----------------
`CHECKIF` - no `D`
================
Comment at: llvm/test/CodeGen/RISCV/float-mem.ll:3
; RUN: llc -mtriple=riscv32 -mattr=+f -verify-machineinstrs < %s \
-; RUN: -target-abi=ilp32f | FileCheck -check-prefix=RV32IF %s
+; RUN: -target-abi=ilp32f | FileCheck -check-prefixes=CHECKIFD,RV32IF %s
; RUN: llc -mtriple=riscv64 -mattr=+f -verify-machineinstrs < %s \
----------------
`CHECKIF`
================
Comment at: llvm/test/CodeGen/RISCV/float-round-conv-sat.ll:3
; RUN: llc -mtriple=riscv32 -mattr=+f -verify-machineinstrs < %s \
-; RUN: -target-abi=ilp32f | FileCheck -check-prefix=RV32IF %s
+; RUN: -target-abi=ilp32f | FileCheck -check-prefixes=CHECKIFD,RV32IF %s
; RUN: llc -mtriple=riscv64 -mattr=+f -verify-machineinstrs < %s \
----------------
`CHECKIF`
================
Comment at: llvm/test/CodeGen/RISCV/half-arith.ll:3
; RUN: llc -mtriple=riscv32 -mattr=+zfh -verify-machineinstrs \
-; RUN: -target-abi ilp32f < %s | FileCheck -check-prefix=RV32IZFH %s
+; RUN: -target-abi ilp32f < %s | FileCheck %s
; RUN: llc -mtriple=riscv64 -mattr=+zfh -verify-machineinstrs \
----------------
`CHECKIFZFH` so that `CHECK` doesn't look like it should cover `RV32I` and `RV64I` too
================
Comment at: llvm/test/CodeGen/RISCV/half-convert-strict.ll:4
; RUN: -target-abi ilp32f -disable-strictnode-mutation < %s \
-; RUN: | FileCheck -check-prefix=RV32IZFH %s
+; RUN: | FileCheck -check-prefixes=CHECKIFD,RV32IZFH %s
; RUN: llc -mtriple=riscv64 -mattr=+zfh -verify-machineinstrs \
----------------
`CHECKIZFH`
================
Comment at: llvm/test/CodeGen/RISCV/half-convert.ll:3
; RUN: llc -mtriple=riscv32 -mattr=+zfh -verify-machineinstrs \
-; RUN: -target-abi ilp32f < %s | FileCheck -check-prefix=RV32IZFH %s
+; RUN: -target-abi ilp32f < %s | FileCheck -check-prefixes=CHECKIFD,RV32IZFH %s
; RUN: llc -mtriple=riscv64 -mattr=+zfh -verify-machineinstrs \
----------------
No F or D here - `CHECKIZFH`
================
Comment at: llvm/test/CodeGen/RISCV/half-fcmp.ll:3
; RUN: llc -mtriple=riscv32 -mattr=+zfh -verify-machineinstrs \
-; RUN: -target-abi ilp32f < %s | FileCheck -check-prefix=RV32IZFH %s
+; RUN: -target-abi ilp32f < %s | FileCheck %s
; RUN: llc -mtriple=riscv64 -mattr=+zfh -verify-machineinstrs \
----------------
`CHECKIZFH`
================
Comment at: llvm/test/CodeGen/RISCV/half-intrinsics.ll:4
; RUN: -verify-machineinstrs -target-abi ilp32f | \
-; RUN: FileCheck -check-prefix=RV32IZFH %s
+; RUN: FileCheck -check-prefixes=CHECKIFD,RV32IZFH %s
; RUN: sed 's/iXLen/i64/g' %s | llc -mtriple=riscv64 -mattr=+zfh \
----------------
`CHECKIZFH`
================
Comment at: llvm/test/CodeGen/RISCV/half-mem.ll:3
; RUN: llc -mtriple=riscv32 -mattr=+zfh -verify-machineinstrs \
-; RUN: -target-abi ilp32f < %s | FileCheck -check-prefix=RV32IZFH %s
+; RUN: -target-abi ilp32f < %s | FileCheck -check-prefixes=CHECKIFD,RV32IZFH %s
; RUN: llc -mtriple=riscv64 -mattr=+zfh -verify-machineinstrs \
----------------
`CHECKIZFH` or `CHECK`
================
Comment at: llvm/test/CodeGen/RISCV/half-round-conv-sat.ll:3
; RUN: llc -mtriple=riscv32 -mattr=+zfh -verify-machineinstrs < %s \
-; RUN: -target-abi=ilp32f | FileCheck -check-prefix=RV32IZFH %s
+; RUN: -target-abi=ilp32f | FileCheck -check-prefixes=CHECKIFD,RV32IZFH %s
; RUN: llc -mtriple=riscv64 -mattr=+zfh -verify-machineinstrs < %s \
----------------
`CHECKIZFH` or `CHECK`
================
Comment at: llvm/test/CodeGen/RISCV/half-round-conv.ll:3
; RUN: llc -mtriple=riscv32 -mattr=+zfh -verify-machineinstrs < %s \
-; RUN: -target-abi=ilp32f | FileCheck -check-prefix=RV32IZFH %s
+; RUN: -target-abi=ilp32f | FileCheck -check-prefixes=CHECKIFD,RV32IZFH %s
; RUN: llc -mtriple=riscv64 -mattr=+zfh -verify-machineinstrs < %s \
----------------
`CHECKIZFH` or `CHECK`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125083/new/
https://reviews.llvm.org/D125083
More information about the llvm-commits
mailing list