[PATCH] D125781: [llvm-dva] 06 - Warning and internal options

[Pavel Samolysov via Phabricator via llvm-commits]

psamolysov added inline comments.


================
Comment at: llvm/include/llvm/DebugInfo/LogicalView/Core/LVSupport.h:163
+    List = new ListType();
+    Map->insert(std::make_pair(Key, List));
+  }
----------------
psamolysov wrote:
> I believe this should work too.
Or, it could be better `Map->emplace(Key, List);`.


================
Comment at: llvm/lib/DebugInfo/LogicalView/Core/LVReader.cpp:41
+    if (Iter == Integrity.end())
+      Integrity.insert(std::make_pair(Element, Scope));
+    else
----------------
psamolysov wrote:
> I believe this should work.
Or, it could be better `Integrity.emplace(Element, Scope);`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125781/new/

https://reviews.llvm.org/D125781