[PATCH] D126637: [Hexagon][test] Fix tests on Linux/musl

Tue May 31 21:32:35 PDT 2022

MaskRay added a comment.

In D126637#3549195 <https://reviews.llvm.org/D126637#3549195>, @awilfox wrote:

> I'm happy to refactor to remove the `-march`; I was just following the rest of the tests in the Hexagon directory that all have this pattern of `-march` followed by `-mtriple` (see the original musl tests added in D72701 <https://reviews.llvm.org/D72701>, and also the OpenBSD test in D126265 <https://reviews.llvm.org/D126265>).  Should we remove the `-march` from the other tests as well?

Yes. Generally `-march` should be avoided for `llc`.

> As for "Linux ABI" vs "musl ABI", D72701 <https://reviews.llvm.org/D72701> and its resultant commit specify:

Thx.

>> Checking OS was too vague and could result in this ABI being unexpectedly enabled if the triple was not set and the host tools were built for Linux. Musl is the only C-library currently used by Hexagon Linux so that is the check I'm using to enable the ABI.
>
> I think the original developers were under the impression that musl wasn't used for development / workstation OS, so they felt this was safe.  Since we at Adélie Linux hadn't been updating our LLVM packaging, we didn't run into this issue until now.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126637/new/

https://reviews.llvm.org/D126637