[PATCH] D126637: [Hexagon][Tests] Fix tests on Linux/musl
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 31 19:50:10 PDT 2022
MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.
> The Linux ABI differs from the non-Linux one with varargs, so this causes the tests to fail.
I think this is incorrect. This is due to difference between linux-gnu and linux-musl.
`-march=hexagon` uses the default target triple (which typically has linux-gnu on a linux-gnu system) and changes the arch part of `hexagon`.
This is subtly different from `-mtriple=...` which sets all components of a target triple.
I think the better fix is to replace -march= with -mtriple=, instead of keeping both.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126637/new/
https://reviews.llvm.org/D126637
More information about the llvm-commits
mailing list