[PATCH] D125847: LTO: Decide upfront whether to use opaque/non-opaque pointer types

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: clang/test/Driver/lto-no-opaque-pointers.c:2
+// UNSUPPORTED: enable-opaque-pointers
+// RUN: %clang -target x86_64-unknown-linux -### %s -flto 2> %t
+// RUN: FileCheck %s < %t
----------------
-target is a legacy option. Use `--target=` for new tests.

No need to use check fd 2 (`2> %t`). There is sufficient coverage testing that the options are in fd 2.

Just use `2>&1 | FileCheck %s`.


================
Comment at: clang/test/Driver/lto-opaque-pointers.c:2
+// REQUIRES: enable-opaque-pointers
+// RUN: %clang -target x86_64-unknown-linux -### %s -flto 2> %t
+// RUN: FileCheck %s < %t
----------------
ditto


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125847/new/

https://reviews.llvm.org/D125847