[PATCH] D125648: [ARM SEH 6] [ARM] Add SEH opcodes in frame lowering

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 31 17:45:10 PDT 2022


efriedma added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMFrameLowering.cpp:304
+  case ARM::t2ADDri12: // add.w r11, sp, #xx
+  case ARM::t2SUBri:   // sub.w r4, r11, #xx
+    // These are harmless if used for just setting up a frame pointer,
----------------
Maybe add t2MOVi16/t2MOVTi16 here?


================
Comment at: llvm/lib/Target/ARM/ARMFrameLowering.cpp:300
+    errs() << "No SEH Opcode for instruction " << TII.getName(Opc) << "\n";
+    std::abort();
+    break;
----------------
report_fatal_error (here and other places you abort()).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125648/new/

https://reviews.llvm.org/D125648



More information about the llvm-commits mailing list