[PATCH] D126722: [BOLT][NFC] Warning for deprecated option '-reorder-blocks=cache+'

Huan Nguyen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 31 16:26:14 PDT 2022


nhuhuan updated this revision to Diff 433225.
nhuhuan added a comment.

Update the warning message for option 'cache+'
Specify the flag options in the warning messages as it would be
exposed to the users.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126722/new/

https://reviews.llvm.org/D126722

Files:
  bolt/lib/Passes/BinaryPasses.cpp


Index: bolt/lib/Passes/BinaryPasses.cpp
===================================================================
--- bolt/lib/Passes/BinaryPasses.cpp
+++ bolt/lib/Passes/BinaryPasses.cpp
@@ -187,8 +187,8 @@
     cl::callback([&](bolt::ReorderBasicBlocks::LayoutType& option) = {
        if (option == bolt::ReorderBasicBlocks::LT_OPTIMIZE_CACHE_PLUS) {
           option = bolt::ReorderBasicBlocks::LT_OPTIMIZE_EXT_TSP;
-	  WithColor::warning() << "option cache+ is deprecated, automatically"
-	                       << "switch to option ext-tsp.\n";
+	  WithColor::warning() << "'-reorder-blocks=cache+' is deprecated, "
+	                << "please use '-reorder-blocks=ext-tsp' instead.\n";
        }
     });
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D126722.433225.patch
Type: text/x-patch
Size: 711 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220531/ff55d049/attachment.bin>


More information about the llvm-commits mailing list